Bug 130 - FMIN/MAX needed
Summary: FMIN/MAX needed
Status: PAYMENTPENDING FIXED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: ALU (including IEEE754 16/32/64-bit FPU) (show other bugs)
Version: unspecified
Hardware: Other Linux
: --- enhancement
Assignee: Michael Nolan
URL:
Depends on:
Blocks: 48
  Show dependency treegraph
 
Reported: 2019-08-07 10:01 BST by Luke Kenneth Casson Leighton
Modified: 2020-02-09 22:00 GMT (History)
2 users (show)

See Also:
NLnet milestone: NLnet.2019.02
total budget (EUR) for completion of task and all subtasks: 200
budget (EUR) for this task, excluding subtasks' budget: 200
parent task for budget allocation: 48
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2019-08-07 10:01:24 BST
FMIN and FMAX needed.
Comment 1 Michael Nolan 2020-01-28 15:09:11 GMT
I'd like to give this one a go if that's alright.
Comment 2 Luke Kenneth Casson Leighton 2020-01-28 15:24:58 GMT
yeah go for it.  here's the scala reference code:
https://github.com/chipsalliance/rocket-chip/blob/master/src/main/scala/tile/FPU.scala#L530
Comment 3 Luke Kenneth Casson Leighton 2020-01-28 22:00:48 GMT
michael i included an import os and os.path.split(__file__) so that the read of the .sby file is location-independent
Comment 4 Michael Nolan 2020-01-28 22:13:51 GMT
> michael i included an import os and os.path.split(__file__) so that the read of > the .sby file is location-independent

I saw that, I made a small change to fix it when running the proof from the proof directory.

I'm planning on refactoring the proof runner into a separate file in fpcommon/ as well.
Comment 5 Luke Kenneth Casson Leighton 2020-01-28 22:28:04 GMT
(In reply to Michael Nolan from comment #4)
> > michael i included an import os and os.path.split(__file__) so that the read of > the .sby file is location-independent
> 
> I saw that, I made a small change to fix it when running the proof from the
> proof directory.
> 
> I'm planning on refactoring the proof runner into a separate file in
> fpcommon/ as well.

have a look at the nmigen/test/test_lib_fifo.py because i don't believe
it's necessary to manually call sby from a subprocess: nmigen should
take care of it.
Comment 6 Luke Kenneth Casson Leighton 2020-01-28 22:29:47 GMT
nmigen/test/utils.py - already done.
Comment 7 Michael Nolan 2020-01-28 23:23:41 GMT
> have a look at the nmigen/test/test_lib_fifo.py because i don't believe
> it's necessary to manually call sby from a subprocess: nmigen should
> take care of it.

That's pretty nice. I was following this tutorial for nmigen's formal verification and it didn't have that: https://github.com/RobertBaruch/nmigen-tutorial/blob/master/8_formal_verification.md
Comment 8 Luke Kenneth Casson Leighton 2020-02-09 20:51:54 GMT
are we happy that this is done, now? unit test seems good.
Comment 9 Michael Nolan 2020-02-09 21:56:22 GMT
> are we happy that this is done, now? unit test seems good.

Yes, I think so. Should I submit an RFP?
Comment 10 Luke Kenneth Casson Leighton 2020-02-09 22:00:26 GMT
do both of them at the same time, create a draft, send it to me
for review.  email me privately.