Bug 431 - need to move FPPipeContext into nmutil
Summary: need to move FPPipeContext into nmutil
Status: RESOLVED FIXED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: Other Linux
: --- enhancement
Assignee: Luke Kenneth Casson Leighton
URL:
Depends on:
Blocks:
 
Reported: 2020-07-15 13:53 BST by Luke Kenneth Casson Leighton
Modified: 2020-07-15 14:56 BST (History)
1 user (show)

See Also:
NLnet milestone: ---
total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0
parent task for budget allocation:
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2020-07-15 13:53:09 BST
https://git.libre-soc.org/?p=ieee754fpu.git;a=blob;f=src/ieee754/fpcommon/getop.py;hb=HEAD

this class is actually part of the ReservationStation API and is being used elsewhere, not specifically for FP.  it therefore needs moving, renaming, and a redirect/substitute dropped in place in the ieee754fpu code.
Comment 1 Luke Kenneth Casson Leighton 2020-07-15 14:43:04 BST
should do the trick:

commit c56a985ee89c38652a0ad38b94624bc6fc62840e (HEAD -> master)
Author: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date:   Wed Jul 15 14:41:35 2020 +0100

    move FPPipeContext to concurrentunit: rename to PipeContext
    see https://bugs.libre-soc.org/show_bug.cgi?id=431

commit e0617970190acd31290ae256f2bb4daff14ea78f (HEAD -> master)
Author: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date:   Wed Jul 15 14:42:39 2020 +0100

    remove FPPipeContext (moved to nmutil), name-substitute on import
    see https://bugs.libre-soc.org/show_bug.cgi?id=431
Comment 2 Luke Kenneth Casson Leighton 2020-07-15 14:56:44 BST
ok that's done.  enough unit tests pass to be confident this is ok,
including running an ieee754fpu unit test involving FPPipeContext.

commit 8d0d071d3f0496b3aef3a82d524171bcfd3316b4
Author: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date:   Wed Jul 15 14:52:12 2020 +0100

    import PipeContext not FPPipeContext