Bug 461 - review use of manual field decoding in pipelines and update CSV files
Summary: review use of manual field decoding in pipelines and update CSV files
Status: CONFIRMED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: Other Linux
: Low enhancement
Assignee: Luke Kenneth Casson Leighton
URL:
Depends on:
Blocks:
 
Reported: 2020-08-18 10:18 BST by Luke Kenneth Casson Leighton
Modified: 2020-08-18 10:19 BST (History)
1 user (show)

See Also:
NLnet milestone: ---
total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0
parent task for budget allocation:
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2020-08-18 10:18:53 BST 
https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/fu/alu/main_stage.py;h=b2d2279cf80dec3670d70e5b65359c92a9794acf;hb=29d0566fd104ab8b9ffd0c460fc7c588a72a340b#l50

example.

here instead of op.is_32bit, the "L" field is used instead, manually decoded.  this tends to suggest a shortcoming in the design, particularly that it is power_decode.py and the CSV files that are supposed to do this job.