Bug 482 - mul ok and ov must not be unconditionally set
Summary: mul ok and ov must not be unconditionally set
Status: RESOLVED FIXED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: Other Linux
: --- enhancement
Assignee: Luke Kenneth Casson Leighton
URL:
Depends on:
Blocks: 383 419
  Show dependency tree / graph
 
Reported: 2020-08-29 23:51 BST by Luke Kenneth Casson Leighton
Modified: 2020-08-30 10:51 BST (History)
1 user (show)

See Also:
NLnet milestone: NLNet.2019.10.043.Wishbone
total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0
parent task for budget allocation: 383
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2020-08-29 23:51:04 BST 
https://bugs.libre-soc.org/show_bug.cgi?id=419#c14

the ov and o ok flags must be much more specifically constrained.

also xer_so output is a Data type so needs copying properly.
Comment 1 Luke Kenneth Casson Leighton 2020-08-30 10:51:50 BST 
commit dc3a864af70e9b227771219d6b5a53296e10b78c (HEAD -> master)
Author: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date:   Sun Aug 30 10:51:30 2020 +0100

    set mul post_stage o.ok only when needed, and fix xer_so pass-through