The BranchTestCase() test suite in TestIssuer began failing after this commit: commit a1698c4d20d224c32daab1e5f41dab53add1d262 Author: Luke Kenneth Casson Leighton <lkcl@lkcl.net> Date: Mon May 17 16:33:31 2021 +0100 update reg sort order in ISACaller src/openpower/decoder/isa/caller.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) I did run: $ make pyfnwriter $ make pywriter The commit before it runs OK. The GeneralTestCase() also fails, on the test_loop case. ====================================================================== FAIL: run_all (soc.simple.test.test_runner.TestRunner) [test_loop] ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/cstrauss/src/soc/src/soc/simple/test/test_runner.py", line 299, in process yield from check_regs(self, sim, core, test, code) File "/home/cstrauss/src/soc/src/soc/simple/test/test_core.py", line 175, in check_regs "cr reg %d not equal %s" % (i, repr(code))) AssertionError: 0 != 4 : cr reg 5 not equal 'bc 4,10,-8' There seems to be some issue with branches.
yep confirmed, this will be due to the ISACaller register order changing from how it's declared in the instruction. i think, only overflow should be re-ordered.
got it, reverted, and pushed. please double-check. thanks Cesar.
It works! I'm closing the bug.