Bug 649 - bug in ISACaller unit tests found during demo video
Summary: bug in ISACaller unit tests found during demo video
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: Luke Kenneth Casson Leighton
Depends on:
Reported: 2021-05-20 15:36 BST by Luke Kenneth Casson Leighton
Modified: 2021-05-20 23:17 BST (History)
1 user (show)

See Also:
NLnet milestone: ---
total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0
parent task for budget allocation:
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:


Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2021-05-20 15:36:28 BST
ERROR: test_branch_ctr (__main__.DecoderTestCase)
Traceback (most recent call last):
  File "openpower/decoder/isa/test_caller.py", line 146, in test_branch_ctr
    sim = self.run_tst_program(program)
  File "openpower/decoder/isa/test_caller.py", line 324, in run_tst_program
    simulator = run_tst(prog, initial_regs)
  File "openpower/decoder/isa/test_caller.py", line 72, in run_tst
  File "/home/src/nmigen/nmigen/sim/core.py", line 165, in run
    while self.advance():
  File "/home/src/nmigen/nmigen/sim/core.py", line 156, in advance
    return self._engine.advance()
  File "/home/src/nmigen/nmigen/sim/pysim.py", line 319, in advance
  File "/home/src/nmigen/nmigen/sim/pysim.py", line 308, in _step
  File "/home/src/nmigen/nmigen/sim/_pycoro.py", line 123, in run
  File "/home/src/nmigen/nmigen/sim/_pycoro.py", line 64, in run
    command = self.coroutine.send(response)
  File "/home/src/nmigen/nmigen/sim/core.py", line 81, in wrapper
    yield from process()
  File "openpower/decoder/isa/test_caller.py", line 65, in process
    yield from simulator.execute_one()
  File "/home/src/openpower-isa/src/openpower/decoder/isa/caller.py", line 861, in execute_one
    yield from self.call(opname)         # execute the instruction
  File "/home/src/openpower-isa/src/openpower/decoder/isa/caller.py", line 1135, in call
    results = info.func(self, *inputs)
  File "/home/src/openpower-isa/src/openpower/decoder/isa/caller.py", line 1318, in decorator
    result = func(*args, **kwargs)
  File "/home/src/openpower-isa/src/openpower/decoder/isa/sprset.py", line 29, in op_mtspr
    SPR[_n] = RS
NameError: name '_n' is not defined
Comment 1 Luke Kenneth Casson Leighton 2021-05-20 23:04:36 BST

re-running unit tests now
Comment 2 Luke Kenneth Casson Leighton 2021-05-20 23:17:23 BST
all good.