Bug 679 - not cherry-picking popcntw XLEN or cnttz XLEN
Summary: not cherry-picking popcntw XLEN or cnttz XLEN
Status: CONFIRMED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: dmitry.selyutin
URL:
Depends on:
Blocks: 671
  Show dependency treegraph
 
Reported: 2021-08-30 14:12 BST by Luke Kenneth Casson Leighton
Modified: 2021-09-04 19:26 BST (History)
1 user (show)

See Also:
NLnet milestone: ---
total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0
parent task for budget allocation:
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2021-08-30 14:12:06 BST
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=ff49e2ca41d621532795f960c715d7b7e9c5379c

https://bugs.libre-soc.org/show_bug.cgi?id=671#c40

the subdivision i think needs to be on the inner loop
not the outer loop
Comment 2 dmitry.selyutin 2021-08-30 20:27:46 BST
(In reply to Luke Kenneth Casson Leighton from comment #0)
> https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;
> h=ff49e2ca41d621532795f960c715d7b7e9c5379c
> 
> https://bugs.libre-soc.org/show_bug.cgi?id=671#c40
> 
> the subdivision i think needs to be on the inner loop
> not the outer loop

Yes, this is a typo. I think my eyes already dazzled at that point. I'll update it.
Comment 4 Luke Kenneth Casson Leighton 2021-08-31 12:22:14 BST
(In reply to dmitry.selyutin from comment #3)
> popcntw -- pushed
> 
> https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;
> h=ab7c88d9a686f341c5af9ffd5b68175e0b67bb55

got it, looks good.  updated to include shortened tempvars
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=cc990388b1f29c87f4d7ff53edbef9d34312b6f8
Comment 5 dmitry.selyutin 2021-09-04 19:26:05 BST
Should this one be closed?