Bug 718 - PartitionedSignal __r*__ functions need review
Summary: PartitionedSignal __r*__ functions need review
Status: CONFIRMED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: Other Linux
: --- enhancement
Assignee: Luke Kenneth Casson Leighton
URL:
Depends on:
Blocks: 132
  Show dependency tree / graph
 
Reported: 2021-10-02 17:21 BST by Luke Kenneth Casson Leighton
Modified: 2022-06-16 15:52 BST (History)
1 user (show)

See Also:
NLnet milestone: NLnet.2019.02.012
total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0
parent task for budget allocation:
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2021-10-02 17:21:06 BST 
reverse-operator functions have completely different behaviour
for non-commutative operators when the rhs is not also a
PartitionedSignal.

the obvious one is shift:

    Signal << PartitionedSignal

is not the same as:

    PartitionedSignal << Signal

yet they both (obviously) return a PartitionedSignal.

__rsub__ is also non-commutative and needs to behave very differently.

there may be others, the full list to be evaluated and added here:

* __rsub__