Bug 750 - Convert pinmux gpio, jtag-block bitmap diagrams to svg vector
Summary: Convert pinmux gpio, jtag-block bitmap diagrams to svg vector
Status: RESOLVED FIXED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: Veera
URL: https://libre-soc.org/docs/pinmux/
Depends on:
Blocks: 50
  Show dependency treegraph
 
Reported: 2021-11-28 15:18 GMT by Veera
Modified: 2022-05-12 00:13 BST (History)
3 users (show)

See Also:
NLnet milestone: NLnet.2019.02.012
total budget (EUR) for completion of task and all subtasks: 500
budget (EUR) for this task, excluding subtasks' budget: 500
parent task for budget allocation: 50
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:
vklr = { amount = 500, submitted = 2022-04-16, paid = 2022-04-28 }


Attachments
ch02-44.svg (31.88 KB, image/svg+xml)
2022-03-22 11:07 GMT, Veera
Details
corrected filled color square to transparent (31.88 KB, image/svg+xml)
2022-03-22 22:55 GMT, Veera
Details
io_tristate_jtag svg image converted from jpg (47.36 KB, image/svg+xml)
2022-03-24 13:25 GMT, Veera
Details
gpio-block image converted from png to svg format (34.34 KB, image/svg+xml)
2022-03-25 07:54 GMT, Veera
Details
jtag-block svg image (54.05 KB, image/svg+xml)
2022-03-27 05:28 BST, Veera
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Veera 2022-03-22 11:07:33 GMT
Created attachment 152 [details]
ch02-44.svg

ch02-44.svg image made from png format. What should this file be named suitably as I cannot guess? And also give me feedback.
Comment 2 Andrey Miroshnikov 2022-03-22 15:44:21 GMT
(In reply to vklr@vkten.in from comment #1)
> ch02-44.svg image made from png format. What should this file be named
> suitably as I cannot guess?

Perhaps "asic_iopad_gen" is a suitable name? Since it's showing an example of a generic IO Pad controlled with an o/oe/i interface.

> And also give me feedback.

The "I/O pad" box in the diagram is filled in with white. Is this intentional?
The other elements (logic gates) don't have any fill.

Also when zooming in I can see the lines and labels are blurred, can this effect be removed?
So that we could scale the diagram to any resolution.
Comment 3 Veera 2022-03-22 22:55:37 GMT
Created attachment 153 [details]
corrected filled color square to transparent

Corrected filled color square box to transparent.
Comment 4 Veera 2022-03-22 23:01:18 GMT
(In reply to Andrey Miroshnikov from comment #2)
> (In reply to vklr@vkten.in from comment #1)
> > ch02-44.svg image made from png format. What should this file be named
> > suitably as I cannot guess?
> 
> Perhaps "asic_iopad_gen" is a suitable name? Since it's showing an example
> of a generic IO Pad controlled with an o/oe/i interface.

I will need a vote from Lkcl.

> 
> The "I/O pad" box in the diagram is filled in with white. Is this
> intentional?

No. I have changed it to transparent. See https://bugs.libre-soc.org/attachment.cgi?id=153

> The other elements (logic gates) don't have any fill.
> 
> Also when zooming in I can see the lines and labels are blurred, can this
> effect be removed?
> So that we could scale the diagram to any resolution.

In my two image viewers they are scaling sharply. No lines and labels blurred! Are you seeing .svg image! The .png may have that blurred effect.
Comment 5 Andrey Miroshnikov 2022-03-22 23:08:09 GMT
(In reply to vklr@vkten.in from comment #4)
> I will need a vote from Lkcl.
Sure.

> > The "I/O pad" box in the diagram is filled in with white. Is this
> > intentional?
> 
> No. I have changed it to transparent. See
Thanks, looks good now.

> In my two image viewers they are scaling sharply. No lines and labels
> blurred! Are you seeing .svg image! The .png may have that blurred effect.
Interesting, inkscape does show it correctly!
I guess my librsvg isn't working properly...hahaha
Comment 6 Veera 2022-03-24 13:25:10 GMT
Created attachment 154 [details]
io_tristate_jtag svg image converted from jpg

io_tristate_jtag image hand converted from jpg to svg.
Please review and give feedback.
Comment 7 Veera 2022-03-25 07:54:08 GMT
Created attachment 155 [details]
gpio-block image converted from png to svg format

gpio-block image converted from png to svg vector format.

Give review and feedback.
Comment 8 Luke Kenneth Casson Leighton 2022-03-25 09:51:38 GMT
(In reply to Andrey Miroshnikov from comment #2)

> Perhaps "asic_iopad_gen" is a suitable name? Since it's showing an example
> of a generic IO Pad controlled with an o/oe/i interface.

it doesn't matter. it came from an online book originally and was clearly
auto-generated.  asic_iopad_gen is as good a name as any.
Comment 9 Veera 2022-03-27 05:28:54 BST
Created attachment 156 [details]
jtag-block svg image

jtag-block jpg image converted to svg vector image.

Kindly review and give feedback.
Comment 10 Veera 2022-03-28 12:41:31 BST
Corrected and uploaded all the svg images and updated pinmux page as well.

uri: https://libre-soc.org/docs/pinmux/
Comment 11 Luke Kenneth Casson Leighton 2022-03-28 13:54:50 BST
(In reply to vklr@vkten.in from comment #10)
> Corrected and uploaded all the svg images and updated pinmux page as well.
> 
> uri: https://libre-soc.org/docs/pinmux/

looks great Veera, there's obviously other diagrams been added,
but these can be done later.

oh, can you put some separation lines into this:
https://libre-soc.org/docs/pinmux/i_o_io_tristate_jtag.svg

* just above the words "Input / Output" and
* just above the word "Tristate"

that will create some separation into 4 "areas"

* Input (top left)
* Output (top right)
* Input/Output (middle)
* Tristate (bottom)

then we're good i think, and this can be closed and submitted
for RFP.  but, can i suggest putting it in after the other
bugreports are done, so you can get one payment and not have
3 International Bank Charges?
Comment 12 Veera 2022-03-29 01:15:48 BST
(In reply to Luke Kenneth Casson Leighton from comment #11)
> (In reply to vklr@vkten.in from comment #10)
> 
> oh, can you put some separation lines into this:
> https://libre-soc.org/docs/pinmux/i_o_io_tristate_jtag.svg
> 
> * just above the words "Input / Output" and
> * just above the word "Tristate"
> 

Put separation lines between them.

> then we're good i think, and this can be closed and submitted
> for RFP.  but, can i suggest putting it in after the other
> bugreports are done, so you can get one payment and not have

Yep. After you suggested work, I will try complete the new two and send RFP.