Bug 767 - fu compunit unit tests no longer function
Summary: fu compunit unit tests no longer function
Status: CONFIRMED
Alias: None
Product: Libre-SOC's second ASIC
Classification: Unclassified
Component: source code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: Luke Kenneth Casson Leighton
URL:
Depends on:
Blocks:
 
Reported: 2022-01-21 19:19 GMT by Luke Kenneth Casson Leighton
Modified: 2022-01-21 19:53 GMT (History)
2 users (show)

See Also:
NLnet milestone: ---
total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0
parent task for budget allocation:
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2022-01-21 19:19:07 GMT 
python3 fu/compunits/test/test_alu_compunit.py

ERROR: run_all (__main__.BranchTestRunner)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/lkcl/src/libresoc/soc/src/soc/fu/compunits/test/test_compunit.py", line 347, in run_all
    m.submodules.cu = cu = self.fukls(0)
TypeError: __init__() missing 1 required positional argument: 'parent_pspec'
Comment 1 Luke Kenneth Casson Leighton 2022-01-21 19:39:32 GMT 
important to keep these functional, jacob. i have an obscure branch unit
test to create that i can't use the standard test_issuer.py for
Comment 2 Jacob Lifshay 2022-01-21 19:53:13 GMT 
Yeah...sorry i missed that test...probably cuz the Python refactoring tool didn't detect that that file was using the FU classes (cuz it's indirect) and the tests I ran never used that file.

AFAICT you already fixed this bug in:
https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=ce5fc12d788e2e6a88cb9f3e071cbc8c0352c13b