Bug 84 - add test for pipelined version of integer multiplier
Summary: add test for pipelined version of integer multiplier
Status: RESOLVED FIXED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: ALU (including IEEE754 16/32/64-bit FPU) (show other bugs)
Version: unspecified
Hardware: Other Linux
: --- enhancement
Assignee: Jacob Lifshay
URL:
Depends on:
Blocks: 60
  Show dependency tree / graph
 
Reported: 2019-05-22 11:26 BST by Jacob Lifshay
Modified: 2019-05-29 11:40 BST (History)
2 users (show)

See Also:
NLnet milestone: ---
total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0
parent task for budget allocation:
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Lifshay 2019-05-22 11:26:30 BST 

    


    


      



        
          Comment 1
        

        
          Jacob Lifshay

        

        
        

        
          2019-05-29 11:11:59 BST
        

      






I finished implementing all the tests for adding pipeline registers and they all pass.

I split the test entry points up so they can be run in parallel by pytest-xdist.

I ran the tests on pypy3 using pytest-xdist on my Ryzen 1500X and it still takes 144s, so, unless you like watching a movie while you wait, don't use plain python3 and unittest :)

All that's left is documentation and code formatting.

    


    


      



        
          Comment 2
        

        
          Luke Kenneth Casson Leighton

        

        
        

        
          2019-05-29 11:39:11 BST
        

      






(In reply to Jacob Lifshay from comment #1)
> I finished implementing all the tests for adding pipeline registers and they
> all pass.

superb.

> I split the test entry points up so they can be run in parallel by
> pytest-xdist.

ah great

> I ran the tests on pypy3 using pytest-xdist on my Ryzen 1500X and it still
> takes 144s, so, unless you like watching a movie while you wait, don't use
> plain python3 and unittest :)

 nniiiice :)

> All that's left is documentation and code formatting.

awesome.  something that satisfies pydocstyle3 is great.  we should
discuss on-list (or better via bug #89)

    


    


      



        
          Comment 3
        

        
          Luke Kenneth Casson Leighton

        

        
        

        
          2019-05-29 11:40:26 BST
        

      






swap dependency.  this bug *blocks* bug #60 rather than is blocked *by* it.
takes getting used to (and i may even have it the wrong way *sigh*)

this is probably correct:
http://bugs.libre-riscv.org/showdependencytree.cgi?id=84&hide_resolved=0