Bug 857 - binutils: provide tests for setvl/svstep/svshape/svremap
Summary: binutils: provide tests for setvl/svstep/svshape/svremap
Status: RESOLVED FIXED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: Dmitry Selyutin
URL: https://libre-soc.org/irclog/%23libre...
Depends on:
Blocks:
 
Reported: 2022-06-15 21:36 BST by Dmitry Selyutin
Modified: 2022-09-01 20:22 BST (History)
2 users (show)

See Also:
NLnet milestone: NLNet.2019.10.032.Formal
total budget (EUR) for completion of task and all subtasks: 650
budget (EUR) for this task, excluding subtasks' budget: 650
parent task for budget allocation: 577
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:
lkcl = { amount = 150, submitted = 2022-08-28, paid = 2022-08-31 } ghostmansd = { amount = 500, submitted = 2022-07-19, paid = 2022-07-22 }


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Selyutin 2022-06-15 21:36:11 BST
Before setvl/svstep/svshape/svremap instructions can be submitted, we must cover these with as+objdump tests, as is common in binutils repository.
Comment 1 Dmitry Selyutin 2022-06-16 15:16:09 BST
OK, setvl test is ready; proceeding to the next ones.
Comment 2 Dmitry Selyutin 2022-06-16 15:20:27 BST
Luke, I've increased the budget as usual so that it can be split, I hope you're OK to split it?
Comment 3 Dmitry Selyutin 2022-06-17 06:12:49 BST
The tests are mostly ready; however, I'm kinda in doubts regarding size of the tests, so I decided to raise the question on the mailing list.

https://sourceware.org/pipermail/binutils/2022-June/121275.html
Comment 4 Luke Kenneth Casson Leighton 2022-06-17 14:10:24 BST
(In reply to Dmitry Selyutin from comment #3)
> The tests are mostly ready; however, I'm kinda in doubts regarding size of
> the tests, so I decided to raise the question on the mailing list.
> 
> https://sourceware.org/pipermail/binutils/2022-June/121275.html

amusing that the reply says it's under 1/10th the size of some of
the other unit tests submitted

https://libre-soc.org/irclog/%23libre-soc.2022-06-17.log.html#t2022-06-17T11:18:09
Comment 5 Dmitry Selyutin 2022-06-17 17:10:06 BST
(In reply to Luke Kenneth Casson Leighton from comment #4)
> amusing that the reply says it's under 1/10th the size of some of
> the other unit tests submitted

Yeah I've also been impressed. :-)

Alan keeps silence, so I will publish the autogenerated tests and wait for a reply there. This cannot be committed until FSF completes the copyright assignment procedures, though. Still, this at least is something to start with.

The script I wrote to generate the tests was quick and dirty, and does not reuse openpower-isa, like it should. It simply relies on my intimate knowledge of pysvp64asm. Still, I think it is sufficient for the first iteration. The correct way to approach this issue is to dive into instruction forms to parse operands, consider their bit-layout and generate tests automatically, as well as binutils operands. Task 838 should give us a good start.
Comment 6 Dmitry Selyutin 2022-06-17 20:11:13 BST
I've just submitted the corresponding patches to binutils mailing list.

https://sourceware.org/pipermail/binutils/2022-June/121284.html
Comment 7 Dmitry Selyutin 2022-06-20 07:02:48 BST
https://sourceware.org/pipermail/binutils/2022-June/121289.html

With this in mind, the only thing that blocks us is FSF copyright assignment. I've filed it on May 25, but received no reply yet. On Jun 17, I've raised the question on state of the art on fsf-records at GNU org, but they also keep silence. Any ideas on what to do next?

That said, I assume the technical part is completed and I can submit RFP. Luke, do you have any objections?
Comment 8 Luke Kenneth Casson Leighton 2022-06-20 10:58:51 BST
(In reply to Dmitry Selyutin from comment #7)

> I've raised the question on state of the art on fsf-records at GNU org, but
> they also keep silence. Any ideas on what to do next?

i've emailed copyright-clerk for you and cc'd you (and alexandre)

> That said, I assume the technical part is completed and I can submit RFP.
> Luke, do you have any objections?

none at all, go for it.
Comment 9 Luke Kenneth Casson Leighton 2022-06-21 21:35:23 BST
https://sourceware.org/pipermail/binutils/2022-June/121322.html
from peter
Comment 10 Luke Kenneth Casson Leighton 2022-06-22 10:49:15 BST
https://sourceware.org/pipermail/binutils/2022-June/121337.html

this needs a little work, dmitry:

* main spec https://libre-soc.org/openpower/sv/
* svp64 https://libre-soc.org/openpower/sv/svp64
* setvl https://libre-soc.org/openpower/sv/setvl/
* remap https://libre-soc.org/openpower/sv/remap/

SV (Simple-V) is a strict RISC-paradigm Scalable Vector Extension for the Power ISA. SVP64 is the 64-bit Prefixed instruction format implementing SV. Funded by NLnet through EU Grants No: 825310 and 825322, SV is in DRAFT form and is to be publicly submitted via the OpenPOWER Foundation ISA Working Group via the newly-created External RFC Process.
Comment 11 Dmitry Selyutin 2022-06-26 20:04:03 BST
Yet another revision of the patches. This time, except for addition of svindex instruction, the changes are rather cosmetic (fixed the links, renamed the field, etc.).

https://sourceware.org/pipermail/binutils/2022-June/121429.html
Comment 12 Luke Kenneth Casson Leighton 2022-07-12 21:40:36 BST
the actual tests are now written
Comment 13 Luke Kenneth Casson Leighton 2022-07-19 13:25:40 BST
Dmitry i am re-submitting this via the "secret" URLs
in one single combined RFP covering #847 #857 and #867
and updating the submitted date to 2022-07-19 on all 3.