Bug 884 - sync pysvp64asm register parsing
Summary: sync pysvp64asm register parsing
Status: RESOLVED FIXED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: Dmitry Selyutin
URL: https://lists.libre-soc.org/pipermail...
Depends on:
Blocks:
 
Reported: 2022-07-05 17:47 BST by Dmitry Selyutin
Modified: 2022-09-01 22:11 BST (History)
4 users (show)

See Also:
NLnet milestone: NLNet.2019.10.031.Video
total budget (EUR) for completion of task and all subtasks: 3500
budget (EUR) for this task, excluding subtasks' budget: 3500
parent task for budget allocation: 232
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:
[lkcl] amount=1250 submitted=2022-07-20 paid=2022-07-21 [ghostmansd] amount=1250 submitted=2022-07-25 paid=2022-08-10 [andrey] amount=1000 submitted=2022-08-24 paid=2022-09-01


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Selyutin 2022-07-05 17:47:58 BST
As it was discussed in both IRC and mailing list, we'd better choose an alternative register naming convention, which follows the principle of least astonishment.

* DONE add *NN and *%NN convention to sv/trans/svp64.py
  *without* removing existing convention.
  NOT to add "*rNNNN" or "*fpNNNN" etc.  numbers ONLY.
* TODO add some actual unit tests test_xyz in sv/trans/svp64.py
  (to replace/rework the existing hack-job in __main__) 
* TODO convert mp3
  https://git.libre-soc.org/?p=openpower-isa.git;a=tree;f=media/audio/mp3;hb=HEAD
* DONE convert decoder/isa/test_caller_*.py unit tests
* DONE convert test/*/*cases*.py unit tests
* TODO update specification
* TODO remove old convention

https://lists.libre-soc.org/pipermail/libre-soc-dev/2022-July/005015.html
Comment 1 Luke Kenneth Casson Leighton 2022-07-05 18:09:51 BST
this is actually quite a big task, because every single unit test will need
conversion to the new format.
Comment 2 Luke Kenneth Casson Leighton 2022-07-05 18:23:08 BST
added (untested) vector-numbering into decode_reg() supporting
"*NNN" and "*%NNN"

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=7bcec293f2761bed16e9f1fddf4469c7398cb32b
Comment 3 Luke Kenneth Casson Leighton 2022-07-05 18:39:42 BST
test_caller_setvl.py done, and corrected decode_reg()

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=acba9ef79852aa50f55d62bb68f7c41ea24852a3
Comment 4 Luke Kenneth Casson Leighton 2022-07-05 18:53:25 BST
test_caller_svp64_mapreduce.py done

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=bed2df9c09a89574689f9502a41e72db87a94575
Comment 5 Luke Kenneth Casson Leighton 2022-07-05 18:58:01 BST
test_caller_setvl_fp.py done

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=9069c3f850a5b867a53f60bef1c35dff7d0777fc
Comment 6 Luke Kenneth Casson Leighton 2022-07-05 19:02:06 BST
convert test_caller_setvl_matrix.py to new vector reg format

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=645fa42ac8d6f8f9cc744e89e6af807df2eca38a
Comment 7 Andrey Miroshnikov 2022-07-05 19:53:36 BST
convert test_caller_svp64_dct.py to new vector numbering convention
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=1ec68cd80266bd4d18a8432afa69d150e4e7d478
Comment 8 Andrey Miroshnikov 2022-07-05 20:22:32 BST
convert test_caller_svp64_bc.py to new vector numbering convention
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=59131336aa7f396b5fb05f35aa7a469d1418f9f7
Comment 9 Andrey Miroshnikov 2022-07-05 22:07:12 BST
convert test_caller_svp64_fft.py to new vector numbering convention
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=77cfaac2ec2feeb93cf14fb19da7fd97e82bb768
Comment 10 Andrey Miroshnikov 2022-07-05 23:05:07 BST
convert test_caller_svp64_ldst.py to new vector numbering convention
convert test_caller_svp64_predication.py to new vector numbering convention
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=0e590433afc3d2e9e0f254bac7e02bf765225a70
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=5b40039f453ebfea731356f9accb42d49a33679e
Comment 11 Andrey Miroshnikov 2022-07-05 23:11:54 BST
convert test_caller_svp64.py to new vector numbering convention
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=b6bac56fbda78762dccd6b8469de23ef56f24212
Comment 12 Luke Kenneth Casson Leighton 2022-07-06 08:12:54 BST
convert test_caller_svstate.py

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=b23801eceac0f70ee681026fc333c1c8ee1a4781
Comment 13 Luke Kenneth Casson Leighton 2022-07-06 08:24:16 BST
convert alu svp64_cases.py

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=ef743108db8f65fcb592b1fb70cc3b24be2826f2
Comment 14 Luke Kenneth Casson Leighton 2022-07-06 08:38:49 BST
convert logical svp64_cases.py

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=9f4fd0f7a613add6f11a7864794164f782f8ac87
Comment 16 Luke Kenneth Casson Leighton 2022-07-20 10:36:20 BST
all converted including media mp3.