Bug 967 - unit test for shift-and-add instruction
Summary: unit test for shift-and-add instruction
Status: RESOLVED FIXED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: Dmitry Selyutin
URL:
Depends on: 966
Blocks:
  Show dependency tree / graph
 
Reported: 2022-10-23 12:02 BST by Luke Kenneth Casson Leighton
Modified: 2023-01-25 20:27 GMT (History)
1 user (show)

See Also:
NLnet milestone: NLnet.2021.02A.052.CryptoRouter
total budget (EUR) for completion of task and all subtasks: 150
budget (EUR) for this task, excluding subtasks' budget: 150
parent task for budget allocation: 840
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:
ghostmansd={amount=150, submitted=2022-12-10, paid=2022-12-30}

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2022-10-23 12:02:22 BST 
testing is needed for the shift-and-add instructions
Comment 1 Dmitry Selyutin 2022-11-01 19:30:01 GMT 
1. Reverted these two commits which restore switch statement.
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=24c996e6b104ae2229ff9acf82e83860ecb26e84
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=e2c3ba9ca73f0775ba75e8447789b92ed01112b8

2. Adjusted the pseudocode so that it avoids the overflow (sm is 2-bit, adding 1 to sm=0x3 wil yield sm=0x0).

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=50eb051ab3b916aab443ea3484a02b00e5a143d0

3. Supported the concatenation for variables deep inside selectable integers (logically this should've been the first).
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=0389a26f6d725335ee1e3d920dc9e87861bff1d6

4. Provided the tests for shadd/shadduw.
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=30e18452e6988016e823cd9b9b6fc4b2d4fa1b57
Comment 2 Dmitry Selyutin 2022-11-06 11:08:08 GMT 
I consider this done, unless there is shaddsw needed too.