I looked and found some more instructions that I think need to change how they're XLEN-ified: I put the changes in the change-xlenification-bug-1064 branch: https://git.libre-soc.org/?p=openpower-isa.git;a=shortlog;h=refs/heads/change-xlenification-bug-1064 https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=c19e4136b5ed830dbf511e53cdf05e53b64936e4
I found them by searching in openpower-isa/openpower/isa for: (?<!OV|CA)(?<![0-9])(7|8|15|16|31|32|63|64)(?![0-9]) basically searching for all powers of 2 and one less from 7 to 64 but ignoring OV32/CA32
(In reply to Jacob Lifshay from comment #0) > I looked and found some more instructions that I think need to change how > they're XLEN-ified: yep doesn't surprise me. btw there's no "see also" bugreports - i only encountered a couple months old by accident on a keyword search. please please for goodness sake do the search straight away on creating a bug and add "see also" and any other cross-referencing.
On branch change-xlenification-bug-1064 https://git.libre-soc.org/?p=openpower-isa.git;a=shortlog;h=b94b04d748729ea8cce3c61e527ced9d3835cff9 commit b94b04d748729ea8cce3c61e527ced9d3835cff9 Author: Jacob Lifshay <programmerjake@gmail.com> Date: Thu Apr 20 20:23:48 2023 -0700 rename/convert/merge XLCASTU/XLCASTS to EXTZXL/EXTSXL commit a4b43d331d625b4d22dd4b718072259cdfc6f4aa Author: Jacob Lifshay <programmerjake@gmail.com> Date: Thu Apr 20 20:15:48 2023 -0700 rewrite all uses of XLCASTU/XLCASTS commit 2994f4876dacca8c81b79f3b45adbd46cc56b3cf Author: Jacob Lifshay <programmerjake@gmail.com> Date: Thu Apr 20 20:13:57 2023 -0700 add EXTZ since it's in PowerISA v3.1B (see lbz for an example)
merged to master. iirc that's all that needs to be changed since we use openpower-isa.git as our only pseudo-code reference for existing PowerISA insns, if there's something I forgot, feel free to re-open.