Bug 728 - ISACaller needs a cleanup and partial re-factoring
Summary: ISACaller needs a cleanup and partial re-factoring
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: Luke Kenneth Casson Leighton
Depends on:
Blocks: 241
  Show dependency treegraph
Reported: 2021-10-13 20:00 BST by Dmitry Selyutin
Modified: 2022-09-01 20:15 BST (History)
2 users (show)

See Also:
NLnet milestone: NLNet.2019.10.046.Standards
total budget (EUR) for completion of task and all subtasks: 1000
budget (EUR) for this task, excluding subtasks' budget: 1000
parent task for budget allocation: 241
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:
red = { amount = 1000, submitted = 2022-08-26, paid = 2022-08-31 }


Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Selyutin 2021-10-13 20:00:48 BST
As it stands, ISACaller, especially its `call` method, needs to be cleaned up. First, some code chunks must be decoupled into standalone functions.
A great care must be taken since this is, essentially, the heart of instruction execution. It _essential_ to re-run all tests we have src/openpower/decoder/isa before committing every single change.

More details at IRC logs: https://libre-soc.org/irclog/%23libre-soc.2021-10-10.log.html#t2021-10-10T15:33:16
Comment 1 Luke Kenneth Casson Leighton 2021-10-13 21:12:33 BST
outline / plan here:
Comment 2 Luke Kenneth Casson Leighton 2022-07-18 21:05:39 BST
commit fe81c308bf8372f346340017a89bee4c4df3e057 (HEAD -> master)
Author: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date:   Mon Jul 18 21:05:27 2022 +0100

    begin function split in ISACaller