Bug 728 - ISACaller needs a cleanup and partial re-factoring
Summary: ISACaller needs a cleanup and partial re-factoring
Status: CONFIRMED
Alias: None
Product: Libre-SOC's first SoC
Classification: Unclassified
Component: Source Code (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: dmitry.selyutin
URL:
Depends on:
Blocks: 241
  Show dependency treegraph
 
Reported: 2021-10-13 20:00 BST by dmitry.selyutin
Modified: 2021-10-13 21:14 BST (History)
2 users (show)

See Also:
NLnet milestone: NLNet.2019.10.Standards
total budget (EUR) for completion of task and all subtasks: 1000
budget (EUR) for this task, excluding subtasks' budget: 1000
parent task for budget allocation: 241
child tasks for budget allocation:
The table of payments (in EUR) for this task; TOML format:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dmitry.selyutin 2021-10-13 20:00:48 BST
As it stands, ISACaller, especially its `call` method, needs to be cleaned up. First, some code chunks must be decoupled into standalone functions.
A great care must be taken since this is, essentially, the heart of instruction execution. It _essential_ to re-run all tests we have src/openpower/decoder/isa before committing every single change.

More details at IRC logs: https://libre-soc.org/irclog/%23libre-soc.2021-10-10.log.html#t2021-10-10T15:33:16
Comment 1 Luke Kenneth Casson Leighton 2021-10-13 21:12:33 BST
outline / plan here:
https://libre-soc.org/irclog/%23libre-soc.2021-10-10.log.html#t2021-10-10T15:33:16